[ProtoApiScrubber] Allow generic matchers to be configured in filter config. #42276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumit Kumar <[email protected]>
Signed-off-by: Sumit Kumar <[email protected]>
adisuissa
reviewed
Dec 1, 2025
| } | ||
| } | ||
|
|
||
| TEST_F(ProtoApiScrubberFilterConfigTest, MatcherInputTypeValidations) { |
Contributor
There was a problem hiding this comment.
What will happen now if a non-supported matcher will be used?
Are there tests that cover that? Would adding an integration test for this use-case make sense?
Member
|
@sumitkmr2 i think this is awaiting your feedback /wait-any |
Contributor
Author
|
Yes, actually I'm on leave right now. I'll respond back this Friday.
…On Mon, Dec 8, 2025, 4:22 PM phlax ***@***.***> wrote:
*phlax* left a comment (envoyproxy/envoy#42276)
<#42276 (comment)>
@sumitkmr2 <https://github.com/sumitkmr2> i think this is awaiting your
feedback
/wait-any
—
Reply to this email directly, view it on GitHub
<#42276 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BOJQTFOTG7N5X5VLSFL7HV34AVJ5XAVCNFSM6AAAAACNJCXSOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRWGMYDAOBZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
/wait-any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Allow generic matchers to be configured in filter config.
Additional Description: The filter, from inception, supported generic matching. Since it was designed keeping CEL matching in mind, the match input type was restricted to CEL. While writing ITs for other types of matching, it was realized that this is an unnecessary restriction and hence, is being removed. The Integration Tests for other types of matching will be added once Integration Test base PR (#42121) is submitted.
Risk Level: None.
Testing: Negative UTs removed.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: None.
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]